Skip to content

Ensure editor and the file to edit can have spaces in them#212

Merged
tleonhardt merged 1 commit intopython-cmd2:masterfrom
kotfu:fix/test_regex_transcript
Aug 20, 2017
Merged

Ensure editor and the file to edit can have spaces in them#212
tleonhardt merged 1 commit intopython-cmd2:masterfrom
kotfu:fix/test_regex_transcript

Conversation

@kotfu
Copy link
Copy Markdown
Contributor

@kotfu kotfu commented Aug 20, 2017

The unit tests monkey patch the os.system call so its hard to verify this actually works.

I tested manually on macOS with python3.6 and spaces in both editor and the filename supplied to the edit command. Both work fine.

@kotfu kotfu requested a review from tleonhardt as a code owner August 20, 2017 05:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 20, 2017

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files           1        1           
  Lines        1166     1166           
=======================================
  Hits         1128     1128           
  Misses         38       38
Impacted Files Coverage Δ
cmd2.py 96.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49d88a...dc0ad81. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants