Ensure editor and the file to edit can have spaces in them#212
Merged
tleonhardt merged 1 commit intopython-cmd2:masterfrom Aug 20, 2017
kotfu:fix/test_regex_transcript
Merged
Ensure editor and the file to edit can have spaces in them#212tleonhardt merged 1 commit intopython-cmd2:masterfrom kotfu:fix/test_regex_transcript
tleonhardt merged 1 commit intopython-cmd2:masterfrom
kotfu:fix/test_regex_transcript
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 1 1
Lines 1166 1166
=======================================
Hits 1128 1128
Misses 38 38
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Aug 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests monkey patch the os.system call so its hard to verify this actually works.
I tested manually on macOS with python3.6 and spaces in both editor and the filename supplied to the edit command. Both work fine.