edit command now uses options decorator#215
Merged
tleonhardt merged 2 commits intomasterfrom Aug 21, 2017
Merged
Conversation
… parsing related to spaces and quotes The recent change of edit to allow spaces means that it can benefit from the better argument parsing cmd2 has for commands implemented using the @options decorator.
Also fixed a 2nd unrelated unit test which sometimes failed on Windows, depending on what tools were installed or not.
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
+ Coverage 96.74% 96.74% +<.01%
==========================================
Files 1 1
Lines 1166 1167 +1
==========================================
+ Hits 1128 1129 +1
Misses 38 38
Continue to review full report at Codecov.
|
tleonhardt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted edit command to an @options command for the better argument parsing related to spaces and quotes
The recent change of edit to allow spaces means that it can benefit from the better argument parsing cmd2 has for commands implemented using the @options decorator.