Revise environment setting documentation #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=====================================
Coverage 97% 97%
=====================================
Files 1 1
Lines 1204 1204
=====================================
Hits 1168 1168
Misses 36 36Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Aug 29, 2017
Member
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
Thank you for updating this outdated documentation and adding a good example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation on implementing your own settings was very out of date, and did not work. I revised it and created a new example to demonstrate how you can utilize this feature.