Skip to content

Conversation

@tleonhardt
Copy link
Member

@tleonhardt tleonhardt commented Sep 6, 2017

Improved poutput() so that it can print falsy things such as integer zero.

The poutput() function has been ruggedized so that it has a better conditional check so that it will actually print
things which are "falsy" but are still convertible to a string.

A few unit tests have been added specifically for the poutput function.

This closes #222

…sy things

The poutput() function has been ruggedized so that it has a better conditional check so that it will actually print
things which are "falsy" but are still convertible to a string.

A few unit tests have been added specifically for the poutput function.
@tleonhardt tleonhardt added this to the 0.7.8 milestone Sep 6, 2017
@tleonhardt tleonhardt self-assigned this Sep 6, 2017
@tleonhardt tleonhardt requested a review from kotfu September 6, 2017 01:45
@codecov
Copy link

codecov bot commented Sep 6, 2017

Codecov Report

Merging #223 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage      97%   96.92%   -0.09%     
==========================================
  Files           1        1              
  Lines        1204     1204              
==========================================
- Hits         1168     1167       -1     
- Misses         36       37       +1
Impacted Files Coverage Δ
cmd2.py 96.92% <100%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5675b...25efdfb. Read the comment docs.

@tleonhardt tleonhardt changed the title Improved poutput() so that it can print an integer zero Improved poutput() so that it can print falsy things Sep 6, 2017
Copy link
Member

@kotfu kotfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@tleonhardt tleonhardt merged commit 6d711bc into master Sep 6, 2017
@tleonhardt tleonhardt deleted the poutput_falsy branch September 6, 2017 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poutput() can not print a zero.

3 participants