Provide method to run multiple commands w/o a cmdloop. #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcmds_plus_hooks can accept multiple commands process the command queue to deal with subsequent commands loaded from scripts without requiring a command loop. This better supports a one-off batch processing scenario. Also fixed the insertion order of commands placed in the command queue by load and _relative_load so that script commands are run in the expected order. Minor tweak to setup instructions in CONTRIBUTING.md to include pyperclip in prerequisites.
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 96.92% 96.94% +0.01%
==========================================
Files 1 1
Lines 1204 1210 +6
==========================================
+ Hits 1167 1173 +6
Misses 37 37
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Sep 22, 2017
Member
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
Thanks for the PR! Everything looks good to me.
| ```bash | ||
| # Install cmd2 prerequisites | ||
| pip install -U six pyparsing | ||
| pip install -U six pyparsing pyperclip |
Member
There was a problem hiding this comment.
Nice catch! I forgot to update this after adding a dependency on pyperclip
Member
|
@alevy03 I forced a merge of the latest stuff from master into this PR. Once all of the unit tests pass, I will merge this PR in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runcmds_plus_hooks can accept multiple commands process the command queue to
deal with subsequent commands loaded from scripts without requiring a command
loop. This better supports a one-off batch processing scenario.
Also fixed the insertion order of commands placed in the command queue by load
and _relative_load so that script commands are run in the expected order.
Minor tweak to setup instructions in CONTRIBUTING.md to include pyperclip in
prerequisites.
closes #224