Fix for #244 #245
Merged
Fix for #244 #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re.escape() changed behavior in python 3.7.
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 1 1
Lines 1221 1221
=======================================
Hits 1177 1177
Misses 44 44
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Jan 7, 2018
| .cache | ||
| *.pyc | ||
| .coverage | ||
| .tox |
Member
There was a problem hiding this comment.
Good catch, that should have always been there ;-)
|
|
||
| def _transform_transcript_expected(self, s): | ||
| """parse the string with slashed regexes into a valid regex""" | ||
| """parse the string with slashed regexes into a valid regex |
| ( 'use 2/3 cup', 'use\ 2\/3\ cup' ), | ||
| ( '/tmp is nice', '\/tmp\ is\ nice'), | ||
| ( 'slash at end/', 'slash\ at\ end\/'), | ||
| # strings with zero or one slash or with escaped slashes means no regular |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.7, the behavior of re.escape() changed. Rework the test cases in test_transcript.py to ensure they run properly on both 3.4-3.6 as well as 3.7.
This closes #244