Check if name is in self.get_names() before removing

[bsquizz]

This is to avoid hitting ERROR: Invalid syntax: list.remove(x): x not in list if a command is added to exclude_from_help which does not exist in the instance.

I ran into this when trying to use 2 nested prompts each with different exclude_from_help lists. Once the second prompt was instantiated, the 'help' command is updated at the class level, so the command list may now be inaccurate for other instances.

Perhaps it should be considered to change exclude_from_help to an instance variable.

[codecov]

Codecov Report

Merging #272 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   91.56%   91.56%   +<.01%     
==========================================
  Files           1        1              
  Lines        1422     1423       +1     
==========================================
+ Hits         1302     1303       +1     
  Misses        120      120

Impacted Files	Coverage Δ
cmd2.py	91.56% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a765e1...d369123. Read the comment docs.

[tleonhardt]

Nice ruggedization. Thanks for the PR!

[tleonhardt]

I agree, exclude_from_help should probably be an instance variable. Now that we are nesting cmd2.Cmd instances to create-submenus, we should probably revisit what attributes should be made instance variables in general. I'll create an Issue for that.