Tab completion #291
Merged
Tab completion #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved path_complete out of the Cmd class Rewrote shell_complete
- Since path_complete got moved outside of cmd2.Cmd and is now a function instead of a method, need to do partial argument binding with functools.partial() instead of functools.partialmethod()
…symbols now tab complete.
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 91.57% 91.45% -0.12%
==========================================
Files 1 1
Lines 1424 1486 +62
==========================================
+ Hits 1304 1359 +55
- Misses 120 127 +7
Continue to review full report at Codecov.
|
Member
|
@kmvanbrunt Before we merge this, I would like to see the following added:
|
tleonhardt
reviewed
Mar 2, 2018
| return app | ||
|
|
||
|
|
||
| def test_cmd2_subcommand_completion_single_end(sc_app): |
Member
There was a problem hiding this comment.
These unit tests for subcommand completion should not be deleted. They should simply be refactored to use index_based_complete() or complete() instead of the old complete_subcommand().
tleonhardt
approved these changes
Mar 2, 2018
Member
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
Looks good. Thanks for including good unit tests and an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds flag-based and index-based tab-completion helper functions.
This closes #288.
Tab completion for subcommand help was also added.
This closes #274