Skip to content

Conversation

@kmvanbrunt
Copy link
Member

Removed abbrev attribute and support for abbreviated commands

This closes #289

@kmvanbrunt kmvanbrunt requested a review from tleonhardt as a code owner March 2, 2018 22:30
@tleonhardt tleonhardt added this to the 0.8.1 milestone Mar 2, 2018
@tleonhardt tleonhardt self-assigned this Mar 2, 2018
@codecov
Copy link

codecov bot commented Mar 2, 2018

Codecov Report

Merging #292 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   91.38%   91.35%   -0.03%     
==========================================
  Files           1        1              
  Lines        1486     1481       -5     
==========================================
- Hits         1358     1353       -5     
  Misses        128      128
Impacted Files Coverage Δ
cmd2.py 91.35% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17781f2...fa9479c. Read the comment docs.

app.stdout = StdOut()
return app

def test_exclude_from_history(abbrev_app, monkeypatch):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add back a much simpler version of this test

tleonhardt
tleonhardt previously approved these changes Mar 2, 2018
Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tleonhardt tleonhardt merged commit 388d486 into master Mar 3, 2018
@tleonhardt tleonhardt deleted the abbrev branch March 3, 2018 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for abbreviated commands

3 participants