Skip to content

Conversation

@tleonhardt
Copy link
Member

Now the Travis CI Linux builds make use of the pytest-forked module to speed up unit tests.

The reason this helps is due to an apparent bug in pyparsing. See Issue #287 for more information.

Also:

  • Removed use of pexpect in unit test along with the single unit test which used it and was skipped on all current CI platforms because it didn't work there.

This closes #293

Due to apparent bugs in pyparsing, this can significantly speed up unit test execution.

Also:
- Removed use of pexpect in unit tests
- The python-forked module doesn't work on Windows
@tleonhardt tleonhardt self-assigned this Mar 3, 2018
@tleonhardt tleonhardt added this to the 0.8.1 milestone Mar 3, 2018
@codecov
Copy link

codecov bot commented Mar 3, 2018

Codecov Report

Merging #294 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   91.35%   91.42%   +0.06%     
==========================================
  Files           1        1              
  Lines        1481     1481              
==========================================
+ Hits         1353     1354       +1     
+ Misses        128      127       -1
Impacted Files Coverage Δ
cmd2.py 91.42% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388d486...bca8454. Read the comment docs.

@tleonhardt tleonhardt merged commit 40b5225 into master Mar 3, 2018
@tleonhardt tleonhardt deleted the pytest_forked branch March 3, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused unit test which uses pexpect

2 participants