Completion tweaks #296
Merged
Completion tweaks #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be an entire completer function
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=========================================
+ Coverage 91.38% 91.48% +0.1%
=========================================
Files 1 1
Lines 1474 1480 +6
=========================================
+ Hits 1347 1354 +7
+ Misses 127 126 -1
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Mar 3, 2018
| # If no path and no search text has been entered, then search in the CWD for * | ||
| if not text and line[begidx - 1] == ' ' and (begidx >= len(line) or line[begidx] == ' '): | ||
|
|
||
| # Readline places begidx after ~ and path separators (/) so we need to extract any directory |
Member
There was a problem hiding this comment.
Thank you for the improved comments throughout these tab-completion helper functions! The behavior of readline is somewhat obscure, so these comments should help with maintainability of this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simplification of completion routines