Skip to content

Conversation

@rowdyrotifer
Copy link
Contributor

  • "cmd" was used instead of "cmd2" in the sentence above the example code.
  • init method in example code was not indented.
  • I think for the little inline example, the more general name StartupApp instead of AliasAndStartup makes sense since the example doesn't really show any more details.

@codecov
Copy link

codecov bot commented Mar 17, 2018

Codecov Report

Merging #320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files           1        1           
  Lines        1622     1622           
=======================================
  Hits         1483     1483           
  Misses        139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00871e3...bb57ac8. Read the comment docs.

=============================
You can load and execute commands from a startup initialization script by passing a file path to the ``startup_script``
argument to the ``cmd.Cmd.__init__()`` method like so::
argument to the ``cmd2.Cmd.__init__()`` method like so::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fix!

class AliasAndStartup(cmd2.Cmd):
def __init__(self):
cmd2.Cmd.__init__(self, startup_script='.cmd2rc')
class StartupApp(cmd2.Cmd):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like this new name better.

@tleonhardt tleonhardt merged commit 7d47784 into master Mar 17, 2018
@tleonhardt tleonhardt deleted the startup_script branch March 17, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants