Display length fix #332
Merged
Display length fix #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=========================================
- Coverage 89.34% 89.2% -0.15%
=========================================
Files 1 1
Lines 1915 1917 +2
=========================================
- Hits 1711 1710 -1
- Misses 204 207 +3
Continue to review full report at Codecov.
|
tleonhardt
previously approved these changes
Mar 31, 2018
| if sys.platform.startswith('win'): | ||
| INSTALL_REQUIRES.append('pyreadline') | ||
| else: | ||
| INSTALL_REQUIRES.append('wcwidth') |
Member
There was a problem hiding this comment.
Do you only need the wcwidth module on non-Windows platforms?
Member
|
You should probably update the Changelog with a comment about this bug fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where display width was not being calculated for display_matches