Removed unnecessary sorting and duplicate removal from the completers… #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… since all results from these functions are returned to complete() which already does these things. These changes also provide better examples of what is required to write a completer and what isn't.
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
========================================
+ Coverage 89.2% 89.5% +0.3%
========================================
Files 1 1
Lines 1917 1906 -11
========================================
- Hits 1710 1706 -4
+ Misses 207 200 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary sorting and duplicate removal from the completers since all results from these functions are returned to complete() which already does these things.
These changes also provide better examples of what is required to write a completer and what isn't.