Pyscript Revamp #379
Merged
Pyscript Revamp #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't handle all argparse argument options yet (nargs, append, flag, probably more) For #368
Added some shared definitions to cmd2/__init__.py -> maybe there's a better place for these? Figured out how to trick bash into showing argument hints. It's a bit weird. Updated all of the tests and examples to import cmd2 resources from their new location without the automatic imports in cmd2/__init__.py For #369
Updated argcomplete_bridge to use new constants/utils.
…ts into argparse command positional and flag arguments. Added initial set of tests
…/bugs.python.org/issue15112 Added additional tests - now at 100% coverage of pyscript_bridge.py Still need handling of special action types: StoreTrue/False, store_const, count
Removed all legacy pystate objects. Changed default behavior to clear _last_result before each command Added utility for creating named tuples with default values Added tests to exercise new changes.
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
=========================================
+ Coverage 91.11% 91.9% +0.78%
=========================================
Files 5 6 +1
Lines 2252 3420 +1168
=========================================
+ Hits 2052 3143 +1091
- Misses 200 277 +77
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will break anything calls commands through 'cmd'.
All commands using argparse can be accessed through a faux python API. All other commands can be accessed with raw strings.
Closes #368