Extract submenu code to a new project #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 89.86% 90.22% +0.35%
==========================================
Files 8 8
Lines 2645 2526 -119
==========================================
- Hits 2377 2279 -98
+ Misses 268 247 -21
Continue to review full report at Codecov.
|
kmvanbrunt
approved these changes
May 10, 2018
Member
kmvanbrunt
left a comment
kmvanbrunt
left a comment
There was a problem hiding this comment.
Thanks for this change. It will make future maintenance of the core a lot easier.
tleonhardt
approved these changes
May 10, 2018
| pass | ||
|
|
||
|
|
||
| def _pop_readline_history(clear_history: bool=True) -> List[str]: |
|
Hi all, cmd2-submenu appears abandoned since 2018. It also cannot be used with cmd2 over version 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submenu code has been extracted and added to a new project at https://github.com/python-cmd2/cmd2-submenu. The new project still needs a little work: better README, deploy to pypi, etc. However, it's far enough along that I think we should remove the code from the main cmd2 project.