Skip to content

Conversation

@kmvanbrunt
Copy link
Member

…can be nested

@kmvanbrunt kmvanbrunt requested a review from tleonhardt as a code owner May 16, 2018 03:12
@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #400 into master will increase coverage by 0.6%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #400     +/-   ##
=========================================
+ Coverage   89.55%   90.15%   +0.6%     
=========================================
  Files           8        8             
  Lines        2528     2530      +2     
=========================================
+ Hits         2264     2281     +17     
+ Misses        264      249     -15
Impacted Files Coverage Δ
cmd2/cmd2.py 91.56% <0%> (+0.9%) ⬆️
cmd2/rl_utils.py 100% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48d6b5...c76a8ac. Read the comment docs.


def complete_alias(self, text, line, begidx, endidx):
""" Tab completion for alias """
alias_names = set(self.aliases.keys())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tleonhardt tleonhardt merged commit a9b7121 into master May 16, 2018
@tleonhardt tleonhardt deleted the complete_alias branch May 16, 2018 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants