Fixes problem with not passing the parameter hint suppression down to… #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sub-commands Added hint suppression on a per-parameter basis Added helper function to force an parameter to fall back to bash completion instead of using Cmd2 completion. - Hinting is still enabled by default but can be suppressed in the helper function.
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
=========================================
- Coverage 89.45% 89.2% -0.25%
=========================================
Files 8 8
Lines 2579 2594 +15
=========================================
+ Hits 2307 2314 +7
- Misses 272 280 +8
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
May 22, 2018
| except AttributeError: | ||
| DEFAULT_COMPLETER = argcomplete.completers.FilesCompleter() | ||
|
|
||
| from cmd2.argparse_completer import ACTION_ARG_CHOICES, ACTION_SUPPRESS_HINT |
Member
There was a problem hiding this comment.
Are you happy with argcomplete_bridge.py depending on argparse_completer.py? If so then everything looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… sub-commands
Added hint suppression on a per-parameter basis
Added helper function to force an parameter to fall back to bash completion instead of using Cmd2 completion.