Updated CODEOWNERS to reflect who the experts are #444
Conversation
…ious code setions This is my quick and dirty attempt at this effort. Please feel free to modify as you see fit.
kotfu
left a comment
kotfu
left a comment
There was a problem hiding this comment.
Looks good to me. What happens if a source file is not referenced in CODEOWNERS? i.e. cmd2.py
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 9 9
Lines 2740 2740
=======================================
Hits 2472 2472
Misses 268 268Continue to review full report at Codecov.
|
|
@kotfu Order is important in the CODEOWNERS file - the last matching pattern has the most precedence. The very first pattern I have in there is the lowest precedence and is the "catch-all" since the pattern is the "*" wildcard - so any files not referenced are caught by that and I get nominated as the reviewer. For cmd2.py I didn't know what to do since all of us are familiar with it and expertise really comes down to specific sections/methods/functions. Any suggestions? |
Also: - Added files to .gitignore for mypy plugin for PyCharm
|
I'm going to go ahead and merge this in. Everyone should feel free to make whatever changes they see fit at any time. |
Tried to update the CODEOWNERS file to accurately reflect which core developers are most familiar with which code files.
This is my quick and dirty attempt at this effort. Please feel free to modify as you see fit.
This closes #443