Fix pyscript related unit tests #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 91.36% 91.37% +<.01%
==========================================
Files 11 11
Lines 2930 2932 +2
==========================================
+ Hits 2677 2679 +2
Misses 253 253
Continue to review full report at Codecov.
|
Member
Author
|
I'm merging this in now since it fixes an annoying bug. We can try to improve further in the future if we like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some unit tests which were failing on Debian 9.5
Actually the unit tests were fundamentally flawed and shouldn't have passed on several systems. They have been significantly improved.
This closes #537