Skip to content

Conversation

@tleonhardt
Copy link
Member

The StdSim class now accepts the following additional arguments in it's __init__() initializer:

  • encoding: str='utf-8'
  • errors: str='replace'

Additionally, the following two methods were added to the StdSim class:

  • getbytes(self) -> bytes
  • readbytes(self) -> bytes

These should prevent errors and improve options when dealing with underlying binary data.

@tleonhardt tleonhardt added this to the 0.9.5 milestone Oct 3, 2018
@tleonhardt tleonhardt self-assigned this Oct 3, 2018
@tleonhardt tleonhardt requested a review from kmvanbrunt October 3, 2018 16:47
@tleonhardt tleonhardt requested a review from kotfu as a code owner October 3, 2018 16:47
@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #564 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   93.11%   93.13%   +0.01%     
==========================================
  Files          11       11              
  Lines        3110     3118       +8     
==========================================
+ Hits         2896     2904       +8     
  Misses        214      214
Impacted Files Coverage Δ
cmd2/utils.py 98.56% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99c094...68d8de8. Read the comment docs.

@tleonhardt tleonhardt merged commit 06bd735 into master Oct 3, 2018
@tleonhardt tleonhardt deleted the stdsim_binary branch October 3, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants