Undefined names: from colorama import Fore, Back #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Fore__ and __Back__ are used on line 128 but they are never defined or imported. That means that they are _undefined names_ which have the potential to raise NameError at runtime. [flake8](http://flake8.pycqa.org) testing of https://github.com/python-cmd2/cmd2 on Python 3.7.1 $ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__ ``` ./examples/plumbum_colors.py:127:21: F821 undefined name 'Fore' color_off = Fore.RESET + Back.RESET ^ ./examples/plumbum_colors.py:127:34: F821 undefined name 'Back' color_off = Fore.RESET + Back.RESET ^ ```
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 92.15% 93.31% +1.16%
==========================================
Files 11 11
Lines 3185 3185
==========================================
+ Hits 2935 2972 +37
+ Misses 250 213 -37
Continue to review full report at Codecov.
|
Member
|
@cclauss Thanks for the PR. It looks like we accidentally have a cut-and-paste error from when we copied this example from another one. The intent is that this example should purely use plumbum instead of colorama. So the Thanks for finding and fixing this bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fore and Back are used on line 128 but they are never defined or imported. That means that they are undefined names which have the potential to raise NameError at runtime.
flake8 testing of https://github.com/python-cmd2/cmd2 on Python 3.7.1
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics