Skip to content

Conversation

@kmvanbrunt
Copy link
Member

Added Statement object to argparse Namespace passed to wrapped functions

@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #649 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   94.32%   94.32%   +<.01%     
==========================================
  Files          11       11              
  Lines        3065     3068       +3     
==========================================
+ Hits         2891     2894       +3     
  Misses        174      174
Impacted Files Coverage Δ
cmd2/parsing.py 100% <100%> (ø) ⬆️
cmd2/cmd2.py 94.42% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0144d8e...cf7cb0c. Read the comment docs.

@kmvanbrunt kmvanbrunt self-assigned this Mar 17, 2019
@kmvanbrunt kmvanbrunt added this to the 0.9.12 milestone Mar 17, 2019
also be colored.
* `help_error` - the error that prints when no help information can be found
* `default_error` - the error that prints when a non-existent command is run
* The `with_argparser` decorators now add the Statement object created when parsing the command line to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From taking a quick look, the changes look fine

@tleonhardt
Copy link
Member

I took another look and it still looks good, so I'll merge it

@tleonhardt tleonhardt merged commit 47dce29 into master Mar 17, 2019
@tleonhardt tleonhardt deleted the cmd_line branch March 17, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants