-
Notifications
You must be signed in to change notification settings - Fork 124
Pipe chaining #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipe chaining #676
Conversation
…pears before a pipe. In that case, the pipe was given precedence even though it appeared later in the command.
…Statement.post_command()
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 95.1% 95.27% +0.16%
==========================================
Files 11 11
Lines 3168 3175 +7
==========================================
+ Hits 3013 3025 +12
+ Misses 155 150 -5
Continue to review full report at Codecov.
|
| * History now shows what was typed for macros and not the resolved value by default. This is consistent with | ||
| the behavior of aliases. Use the `expanded` or `verbose` arguments to `history` to see the resolved value for | ||
| the macro. | ||
| * Fixed parsing issue in case where output redirection appears before a pipe. In that case, the pipe was given |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains a really nice set of enhancements and bug fixes that make cmd2 applications behave significantly closer to how a "normal" shell behaves. Nice work!
|
@kmvanbrunt @kotfu Do either of you understand the AppVeyor Windows CI failures? From what I can see they are not actually related to this PR, but are some systematic problem with AppVeyor at the moment and/or how we have it configured. However our AppVeyor configuration hasn't changed recently in 7 months. |
|
I pushed a trivial update to to README.md on the master branch and verified that the AppVeyor issue is completely unrelated to anything on this branch. |
Statement.pipe_tofrom a list to a string.Statement.output_tofor use inStatement.post_command()