Skip to content

Conversation

@tleonhardt
Copy link
Member

@tleonhardt tleonhardt commented Jun 15, 2019

Removed extra dependencies and imports required by Python 3.4 as well as unit testing on Python 3.4 from all platform.s

Added support for Python 3.8 in setup.py and unit testing for python 3.8beta on Travis CI.

Now that we support Python 3.5+, this opens up the possibility for beginning to use libraries like pathlib.

Closes #661
Closes #693

TODO:

  • Updated CHANGELOG

@tleonhardt tleonhardt added this to the 0.9.14 milestone Jun 15, 2019
@tleonhardt tleonhardt requested a review from kmvanbrunt June 15, 2019 03:16
@tleonhardt tleonhardt requested review from anselor and kotfu as code owners June 15, 2019 03:16
@tleonhardt tleonhardt self-assigned this Jun 15, 2019
@codecov
Copy link

codecov bot commented Jun 15, 2019

Codecov Report

Merging #700 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
- Coverage   95.47%   95.45%   -0.03%     
==========================================
  Files          11       11              
  Lines        3251     3255       +4     
==========================================
+ Hits         3104     3107       +3     
- Misses        147      148       +1
Impacted Files Coverage Δ
cmd2/cmd2.py 95.58% <100%> (-0.06%) ⬇️
cmd2/pyscript_bridge.py 100% <100%> (ø) ⬆️
cmd2/parsing.py 100% <0%> (ø) ⬆️
cmd2/plugin.py 100% <0%> (ø) ⬆️
cmd2/history.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ac00c...7a30803. Read the comment docs.

kmvanbrunt
kmvanbrunt previously approved these changes Jun 15, 2019
@tleonhardt tleonhardt merged commit b375999 into master Jun 15, 2019
@tleonhardt tleonhardt deleted the deprecate_34 branch June 15, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Begin testing early versions of Python 3.8 on one CI system Discuss when we should end support for Python 3.4

3 participants