Skip to content

Conversation

@kmvanbrunt
Copy link
Member

No description provided.

@kmvanbrunt kmvanbrunt requested a review from tleonhardt July 21, 2019 02:54
@kmvanbrunt kmvanbrunt requested a review from kotfu as a code owner July 21, 2019 02:54
@tleonhardt tleonhardt added this to the 0.9.15 milestone Jul 21, 2019
@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #737 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage    97.2%   97.25%   +0.04%     
==========================================
  Files          13       13              
  Lines        3405     3427      +22     
==========================================
+ Hits         3310     3333      +23     
+ Misses         95       94       -1
Impacted Files Coverage Δ
cmd2/py_bridge.py 100% <100%> (ø)
cmd2/argparse_completer.py 100% <100%> (ø) ⬆️
cmd2/argparse_custom.py 93.79% <100%> (ø) ⬆️
cmd2/cmd2.py 96.66% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578593f...4b91f63. Read the comment docs.

tleonhardt
tleonhardt previously approved these changes Jul 21, 2019
* Fixed bug where `history -v` was sometimes showing raw and expanded commands when they weren't different
* Fixed bug where multiline commands were having leading and ending spaces stripped. This would mess up quoted
strings that crossed multiple lines.
* Fixed a bug when appending to the clipboard where contents were in reverse order
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still looks good

@tleonhardt tleonhardt merged commit 73d1c34 into master Jul 21, 2019
@tleonhardt tleonhardt deleted the renames branch July 21, 2019 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants