Skip to content

Conversation

@kmvanbrunt
Copy link
Member

No description provided.

@kmvanbrunt kmvanbrunt requested a review from tleonhardt July 22, 2019 02:42
@kmvanbrunt kmvanbrunt requested a review from kotfu as a code owner July 22, 2019 02:42
tleonhardt
tleonhardt previously approved these changes Jul 22, 2019
Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #738 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage   97.25%   97.28%   +0.02%     
==========================================
  Files          13       13              
  Lines        3427     3427              
==========================================
+ Hits         3333     3334       +1     
+ Misses         94       93       -1
Impacted Files Coverage Δ
cmd2/cmd2.py 96.66% <100%> (ø) ⬆️
cmd2/utils.py 98.18% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d1c34...11cb8c0. Read the comment docs.

In all cases in which function/methods are passed you can use functools.partial() to prepopulate
values of the underlying function.
You can use functools.partial() to prepopulate values of the underlying choices and completer functions/methods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comments added

@kmvanbrunt kmvanbrunt merged commit 089c8ea into master Jul 22, 2019
@kmvanbrunt kmvanbrunt deleted the presentation_changes branch July 22, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants