Skip to content

Conversation

@tleonhardt
Copy link
Member

Fix what is fundamentally a Pyperclip bug on headless Linux systems without Gtk libraries.

Closes #768

@tleonhardt tleonhardt added the bug label Sep 2, 2019
@tleonhardt tleonhardt added this to the 0.9.17 milestone Sep 2, 2019
@tleonhardt tleonhardt requested a review from kotfu September 2, 2019 15:43
@tleonhardt tleonhardt self-assigned this Sep 2, 2019
Copy link
Member

@kmvanbrunt kmvanbrunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since can_clip can now be set to False even when Pyperclip is installed, we should be more specific in the error message printed by cmd2.py.

"Cannot redirect to paste buffer; install 'pyperclip' and re-run to enable"

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #769 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage    97.3%   97.33%   +0.02%     
==========================================
  Files          13       13              
  Lines        3457     3457              
==========================================
+ Hits         3364     3365       +1     
+ Misses         93       92       -1
Impacted Files Coverage Δ
cmd2/cmd2.py 96.74% <100%> (ø) ⬆️
cmd2/clipboard.py 100% <100%> (ø) ⬆️
cmd2/utils.py 98.2% <0%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6549c8...152a3c2. Read the comment docs.

@tleonhardt tleonhardt merged commit 693ec59 into master Sep 6, 2019
@tleonhardt tleonhardt deleted the headless_linux branch September 6, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors while running from console

3 participants