do_history no longer calls do_edit #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmonly overridden
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 96.93% 96.93% +<.01%
==========================================
Files 14 14
Lines 3490 3491 +1
==========================================
+ Hits 3383 3384 +1
Misses 107 107
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Oct 31, 2019
| # noinspection PyTypeChecker | ||
| self.do_edit(quoted_fname) | ||
|
|
||
| self._run_editor(fname) |
Member
There was a problem hiding this comment.
Not directly calling the edit command see within the history command is a good thing as it removes the possibility of a pathological infinite loop which then allows us to put edit commands in the history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do_history no longer calls do_edit since edit is a command that is commonly overridden
Fixes #793