Recursively set parser.prog #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the command name and not sys.argv[0]
…ince this is no longer needed
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
==========================================
+ Coverage 96.93% 96.97% +0.03%
==========================================
Files 14 14
Lines 3491 3499 +8
==========================================
+ Hits 3384 3393 +9
+ Misses 107 106 -1
Continue to review full report at Codecov.
|
# Conflicts: # CHANGELOG.md
tleonhardt
approved these changes
Oct 31, 2019
|
|
||
| def with_argparser_and_unknown_args(argparser: argparse.ArgumentParser, *, | ||
| # noinspection PyProtectedMember | ||
| def set_parser_prog(parser: argparse.ArgumentParser, prog: str): |
Member
There was a problem hiding this comment.
Would this utility function be more appropriate in argparse_custom.py or here?
Actually, it begs the question would all of the decorators and associated utility functions belong better in a separate file?
| alias_epilog = ("See also:\n" | ||
| " macro") | ||
| alias_parser = Cmd2ArgumentParser(description=alias_description, epilog=alias_epilog, prog='alias') | ||
| alias_parser = Cmd2ArgumentParser(description=alias_description, epilog=alias_epilog) |
Member
There was a problem hiding this comment.
This is a very nice little improvement that provides a better user experience. Thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer necessary to set the
progattribute of an argparser with subcommands. cmd2 now automatically sets the prog value of it and all its subparsers so that all usage statements contain the top level command name and not sys.argv[0].