Skip to content

Conversation

@kmvanbrunt
Copy link
Member

Closes #814
Updated arguments to pfeedback and ppaged for consistency with other cmd2 print functions

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #816 into master will decrease coverage by 0.05%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #816      +/-   ##
=========================================
- Coverage   97.26%   97.2%   -0.06%     
=========================================
  Files          14      14              
  Lines        3506    3506              
=========================================
- Hits         3410    3408       -2     
- Misses         96      98       +2
Impacted Files Coverage Δ
cmd2/cmd2.py 96.43% <44.44%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cad8d9...389f356. Read the comment docs.

tleonhardt
tleonhardt previously approved these changes Nov 23, 2019
    - end was not being passed to poutput()
    - msg object was not being converted string before empty string check
@tleonhardt tleonhardt merged commit 7dbb331 into master Nov 23, 2019
@tleonhardt tleonhardt deleted the pfeedback branch November 23, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pfeedback() needs similar arguments as poutput()

3 participants