Set max version restriction for coverage dependency #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
==========================================
+ Coverage 96.23% 97.35% +1.12%
==========================================
Files 14 14
Lines 3557 3557
==========================================
+ Hits 3423 3463 +40
+ Misses 134 94 -40
Continue to review full report at Codecov.
|
tleonhardt
changed the title
kmvanbrunt
approved these changes
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces using
coverageversions prior to 5.0 since it was a change in this transitive dependency which caused our Windows unit tests to start failing on AppVeyor about 20 days ago.Closes #836