pyscript fixes #888
Merged
pyscript fixes #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug where cmd2 set sys.path[0] for a pyscript to its cwd instead of the script's directory.
Fixed bug where sys.path was not being restored after a pyscript ran.
Setting the following pyscript variables:
__name__: __main__
__file__: script path (as typed)
Removed do_py.run() function since it didn't handle arguments and offered no benefit over run_pyscript.
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
- Coverage 97.44% 97.44% -0.01%
==========================================
Files 14 14
Lines 3684 3680 -4
==========================================
- Hits 3590 3586 -4
Misses 94 94
Continue to review full report at Codecov.
|
kmvanbrunt
changed the title
tleonhardt
requested changes
Feb 15, 2020
| * Renamed set command's `-l/--long` flag to `-v/--verbose` for consistency with help and history commands. | ||
| * Setting the following pyscript variables: | ||
| * `__name__`: __main__ | ||
| * `__file__`: script path (as typed, ~ will be expanded) |
Member
There was a problem hiding this comment.
Should the removal of do_py.run() be mentioned?
tleonhardt
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd2.Cmd.py_localsdictionary.__name__: main__file__: script path (as typed, ~ will be expanded)do_py.run()function since it didn't handle arguments and offered no benefit over run_pyscript.