Skip to content

Conversation

@kmvanbrunt
Copy link
Member

Since CompletionError handling has been moved from ArgparseCompleter to complete(), there is no longer a need to suppress tab hints in the top-level parser for do_set.

…to complete(), there is no longer a need

to suppress tab hints in the top-level parser for do_set.
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #897 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #897   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          15       15           
  Lines        3677     3677           
=======================================
  Hits         3583     3583           
  Misses         94       94
Impacted Files Coverage Δ
cmd2/cmd2.py 96.66% <ø> (ø) ⬆️
cmd2/utils.py 97.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22de858...ce87cb4. Read the comment docs.

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@kmvanbrunt kmvanbrunt merged commit fea1bc1 into master Feb 21, 2020
@kmvanbrunt kmvanbrunt deleted the no_suppress_hint branch February 21, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants