Development settings update #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
messense
commented
Jul 2, 2015
messense
commented
- Add requirements.txt as pre-requirements to dev-requirements.txt.
- Add autoenv .env file to activate virtualenv automatically
Contributor
There was a problem hiding this comment.
我当时把requirements.txt和dev-requirements.txt分开的原因. 就是希望想跑起来firefly的人 和想去给firefly贡献代码, 开发它的人区分开. 也就是一个人可能不需要安装dev-requirements.txt的东西
Contributor
Author
There was a problem hiding this comment.
这里的做法是把 requirements.txt 作为 dev-requirements.txt 的前置要求，并不影响希望想跑起来firefly的人啊，他们还是直接 pip install -r requirements.txt。但对开发它的人来说只要 pip install -r dev-requirements.txt 一下 dev 和 requirements.txt 的东西都装好了，否则还得装好几次。
Contributor
Author
There was a problem hiding this comment.
开发它的人肯定 dev 和 requirements.txt 的东西都得装吧。
Member
There was a problem hiding this comment.
@dongweiming 我同意 @messense 说的，安装dev-requirements的人也会去安装requirements
Contributor
|
刚才去看了下autoenv #TIL |
dongweiming
added a commit
that referenced
this pull request
Jul 2, 2015
Development settings update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.