This repository was archived by the owner on Dec 11, 2021. It is now read-only.
Make development workflow easier to use#18
Closed
doublevcodes wants to merge 25 commits into
Closed
Conversation
D0rs4n
reviewed
Oct 6, 2021
jchristgit
reviewed
Oct 6, 2021
…tion to be consistent
Lines 34-40 have been commented out since flake8 seems to be called incorrectly by pre-commit. Running the command in a terminal (not in pre-commit) seems to be working fine.
Shivansh-007
suggested changes
Nov 2, 2021
Shivansh-007
left a comment
Shivansh-007
left a comment
There was a problem hiding this comment.
The branch wasn't merged properly with main, and leaves out a few changes in the pyproject.toml file, for example, psycopg2-binary is left out.
D0rs4n
added
area: dependencies
type: enhancement
|
@doublevcodes Whats the status of this PR? |
Shivansh-007
approved these changes
Nov 16, 2021
Shivansh-007
left a comment
Shivansh-007
left a comment
There was a problem hiding this comment.
Would you like to add a workflow to check black formatting? Basically, check if there is a black diff (black . --check --diff).
Other than that and the changes required by Chris, everything looks good 👍🏻
ChrisLovering
suggested changes
Nov 20, 2021
This was done because isort was assuming that alembic was a 1st party lib and so placing it incorrectly in imports
Contributor
|
Closing this per us sunsetting this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the overall development experience with the API project. The changes I'm planning on are outlined as follows:
isortinstead offlake8-import-order~=format of pinning dependencies in accordance with other Python Discord projects