This repository was archived by the owner on Dec 11, 2021. It is now read-only.
Migrate reminder endpoints over from site, set up the testing suite#30
Closed
D0rs4n wants to merge 10 commits into
Closed
Migrate reminder endpoints over from site, set up the testing suite#30D0rs4n wants to merge 10 commits into
D0rs4n wants to merge 10 commits into
Conversation
- Add an Init sql script to create a test database that can be used for testing purposes. - Create a pytest 'conftest' with global fixtures for future testing purposes - Implement Reminder tests in an async manner. - Add an additional fixture to properly access instance attributes in async pytest fixtures
D0rs4n
added
area: back-end
area: CI
onerandomusername
suggested changes
Nov 22, 2021
onerandomusername
left a comment
onerandomusername
left a comment
There was a problem hiding this comment.
Seems okay for what it does.
Would like to see a few sentences in the readme to clarify that the database must exist to run the tests at this point.
OR as discussed on discord, recommend running the tests on docker if support is added. 👍
- This commit adds a task that runs the tests inside docker - It also introduces changes to the README regarding the instructions of how to run tests.
- This commit also patches a minor issue regarding how pydantic and FastAPI parses the `expiration` field when issuing a PATCH request.
Shom770
approved these changes
Nov 29, 2021
Shom770
left a comment
Shom770
left a comment
There was a problem hiding this comment.
LGTM! Maybe a few more places that could use more comments/explanation but otherwise it looks good to me
Contributor
Author
Thank you for the review, I've addressed a few changes regarding code consistency, and comments. |
Contributor
|
Closing this in coordination with Joe per us sunsetting this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Closes #31