Fix Docker Compose & Add Boilerplate Project #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for bot-core failed.
|
HassanAbouelela
added
t: enhancement
a: other
Member
|
@HassanAbouelela rebase |
ChrisLovering
requested changes
Jul 23, 2022
HassanAbouelela
force-pushed
the
better-development
branch
from
69ae0b0 to
baa8806
Compare
ChrisLovering
approved these changes
Jul 23, 2022
aiodns is required by aiohttp when using an AsyncResolver, as is done in BotBase. This makes aiodns a required dependency. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Adds a bare-bones discord.py bot using features from bot-core, to be used for quickly prototyping and testing out bot-core features. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Rewrites the docker configuration to better work for this project. A docker compose containing the dependencies from our other projects is also included to help aid development. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Co-authored-by: Chris Lovering <chris.lovering.95@gmail.com> Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
better-development
branch
from
baa8806 to
0e0b893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works on the developer experience for bot-core by adding better infrastructure and boilerplate to help developers test out their changes. This is achieved by adding prominent documentation which explains how to test features in sample and real projects, adding a sample project which contains all the boilerplate for rapid prototyping, and a fixed docker configuration which should work better for this project.
I also added aiodns as an explicit dependency. Our downstream projects already have it so they don't encounter issues, but for local testing it had to be added. We should remove it downstream as well.