Sync global and guild app command tree on startup #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
Author
|
I have also made this available for testing on this PR python-discord/sir-robin#71 |
ChrisLovering
force-pushed
the
sync-tree-on-startup
branch
from
5742596 to
c4d5630
Compare
shtlrs
approved these changes
Jan 8, 2023
Member
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
LGTM, tested & my commands sync as usual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change syncs all app commands after extensions have been loaded.
This release also removes the need to run :obj:
pydis_core.BotBase.load_extensionsin a task, and it can just be awaited directly.A beta release for this PR is available under
9.4.0b1on pypi.Changelog preview:
Docstring:
Approach
I specifically decided to go with a on-startup sync, rather than command based as it does not require us to manually call a command after merging a PR with a new/update to an app command.
There is a ratelimit on syncing global commands which add new commands (200 commands per guild per day), however updating commands (currently) has no ratelimit.