-
-
Notifications
You must be signed in to change notification settings - Fork 17
Make the aoc join command a slash command.
#71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `aoc join` was migrated to use the slash command interface, for convenience
Co-Authored-By: ChrisJL <ChrisLovering@users.noreply.github.com>
janine9vn
approved these changes
Dec 7, 2022
Collaborator
janine9vn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, but I won't block because of it since it's ultra minor
ChrisLovering
approved these changes
Dec 22, 2022
Member
|
Just minor comments, feel free to merge with or without them |
Co-authored-by: ChrisJL <ChrisLovering@users.noreply.github.com>
df0cd51 to
314d837
Compare
This removes the need to manually sync commands, as this is now handled in bot-core.
314d837 to
709c0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64