Add a decorator that stops successive duplicate invocations of commands #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for bot-core failed.
|
MarkKoz
requested changes
Jun 19, 2022
Co-authored-by: MarkKoz <KozlovMark@gmail.com>
Numerlor
force-pushed
the
no-duplicate-deco
branch
from
f185070 to
7721047
Compare
Numerlor
force-pushed
the
no-duplicate-deco
branch
from
7721047 to
c3814a2
Compare
Numerlor
force-pushed
the
no-duplicate-deco
branch
from
c3814a2 to
805c604
Compare
HassanAbouelela
added
a: code
the package now requires python 3.10
MarkKoz
requested changes
Sep 18, 2022
Member
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
Hey, I forgot about this PR. Sorry it took me so long to take notice again. Just have some small suggestions.
Contributor
Author
|
For the failing doc I've opened tox-dev/sphinx-autodoc-typehints#255 |
MarkKoz
approved these changes
Sep 19, 2022
Member
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
I'm out of my depth with the sphinx changes you've made, so I'll defer reviews of that to someone more experienced.
while only iterable is strictly needed, any reader would expect the function to return a tuple
ChrisLovering
approved these changes
Sep 20, 2022
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
Looks good to me. Once sphinx-autodoc-typehints makes a release with your change we can get this updated and merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports over
update_wrapper_globals/command_wrapsand adds a decorator that stops successive duplicate invocations of a command with the same arguments in the same channel.I've extended the source lookup func for linkcode to also look into if statements for the
if TYPE_CHECKINGuse and added a guard to prevent if from erroring on cases that aren't taken care of. It's still missing on some different cases where assignments could occur but that can be addressed in a different PR specifically for thatcloses: #87