Python community & partners get same access as staff

[ChrisLovering]

I'd like to propose that everywhere in the bot (barring talent pool) that uses STAFF_ROLES as a check is changed to also include both python community and partners as passing that check.

These places would be:

• Duck pond (for seeing if a message was from a staff member)
• Help command (Posts output in channel, rather then being relayed to bot-commands)
• Role list (a command to list all roles)
• Role info (a command to get info on a given role)
• User info (Posts output in channel, rather then being relayed to bot-commands)
• Raw command (Bypasses cooldown, and allows them to run it in any channel)
• List stream (Ignores them in output of list stream, as they have explicit stream permissions like staff anyway
• Ping (Allows them to run it in any channel)
• Reminder (Allow them to run it in any channel)
• Charinfo (Allow them to run it in any channel)

[Akarys42]

I agree with all of this, except for #duck-pond, since they don't have access to that channel, I don't think it would make sense to be able to duck their messages.

[ChrisLovering]

I agree with all of this, except for #duck-pond, since they don't have access to that channel, I don't think it would make sense to be able to duck their messages.

Yup, that sounds good. Seems like 3 core devs are in agreement, I'll approve this :)

[TizzySaurus]

I'd be interested in working on this, but need to know what approach we'd like to take.

Would it simply be a case of changing has_no_roles_check(*STAFF_ROLES) to has_no_roles(*STAFF_ROLES, Roles.partners, Roles.python_community), or do we want to add some sort of separate roles-category for this?

[Akarys42]

I'd be interested in working on this, but need to know what approach we'd like to take.

Would it simply be a case of changing has_no_roles_check(*STAFF_ROLES) to has_no_roles(*STAFF_ROLES, partners, python_community), or do we want to add some sort of separate roles-category for this?

What I would do is add the two roles to the existing STAFF_ROLES constant. You can then explicitly list all of those roles except partners and community members in the duck pond cog.

[ChrisLovering]

Hhmm, we may want to add a new constant, that's staff + the two new roles, since the staff roles constant will still be used in some places (duck pond and talent pool)

[Akarys42]

Right, I forgot about talent pool. Let's do that then.

[TizzySaurus]

What do we want to call the constant? Perhaps STAFF_PARTNERS_COMMUNITY?

[ChrisLovering]

Probably want to put _ROLES on the end too, for consistency with other constants.

[TizzySaurus]

True. STAFF_PARTNERS_COMMUNITY_ROLES seems good I think.