Clean: _delete_found doesn't handle NotFound

[sentry]

The _delete_found doesn't properly handle the NotFound exception, a contextlib.suppress block should be added to prevent the exception from propagating.

Sentry Issue: BOT-1QH

NotFound: 404 Not Found (error code: 10008): Unknown Message
  File "discord/http.py", line 331, in request
    raise NotFound(response, data)
  File "discord/channel.py", line 403, in delete_messages
    await self._state.http.delete_message(self.id, message_id)
  File "bot/exts/moderation/clean.py", line 296, in _delete_found
    await channel.delete_messages(to_delete)
  File "bot/exts/moderation/clean.py", line 408, in _clean_messages
    deleted_messages = await self._delete_found(message_mappings)
  File "bot/exts/moderation/clean.py", line 480, in clean_user
    await self._clean_messages(ctx, traverse, users=[user], channels=channels, use_cache=use_cache)
...
(1 additional frame(s) were not displayed)

Error executing command invoked by [REDACTED]: !clean user [REDACTED] 20 0 *

[ChrisLovering]

Something worth mentioning if it's useful is that channel.delete_messages() special cases when you send it an iterable with just 1 element. In this case, it uses the normal delete_message() function. Whereas if you pass it more than 1, it uses bulk_delete, which does not raise any errors.

[Hashed0719]

Something worth mentioning if it's useful is that channel.delete_messages() special cases when you send it an iterable with just 1 element. In this case, it uses the normal delete_message() function. Whereas if you pass it more than 1, it uses bulk_delete, which does not raise any errors.

does that mean delete_message() is raising error because an iterable is passed to it?

[ChrisLovering]

No, this means that channel.delete_messages() will only raise a message not found error for the case where an iterable of length 1 is passed to it, since then it will just use the delete singular method.

For actual bulk-deletion channel.delete_messages() ignores that error.

[Hashed0719]

so basically it needs await channel.delete_messages(to_delete) to be under a suppress block right? @ChrisLovering

[ChrisLovering]

yup, that could work

[ichard26]

Closing as resolving PR #1976 was merged. FYI @git-zephyrus any variation of solve won't work, you'll need to use fix, close, or resolve (or their plural / past tense forms).

[Hashed0719]

any variation of solve won't work, you'll need to use fix, close, or resolve (or their plural / past tense forms).

@ichard26 Sorry I don't get what you mean?

Do you mean that I had to close issues and PR after fixing them ?

[ichard26]

You can use special keywords in the PR description so GitHub will automatically close an issue upon merge. You can read more here: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword. This makes sure any issue that should be closed are in fact closed (and I won't have to go proactively hunt for such issues!), keeping our issue tracker ever so slightly less chaotic and scary :)

I thought you knew about this feature but simply had forgotten that solve won't work :)

[Hashed0719]

Oh. No, I didn't knew actually this was my first commit. Anyways thanks for telling, will make sure next time.