AttributeError: 'NoneType' object has no attribute 'fetch_message'

[sentry]

Sentry Issue: BOT-9M

AttributeError: 'NoneType' object has no attribute 'fetch_message'
  File "discord/client.py", line 351, in _run_event
    await coro(*args, **kwargs)
  File "bot/exts/moderation/modlog.py", line 732, in on_raw_message_edit
    message = await channel.fetch_message(event.message_id)

Unhandled exception in on_raw_message_edit.

This is caused by the on_raw_message_edit triggering before the guild cache is ready.

A fix for this would be to add a await self.bot.wait_until_guild_available() to all events that rely on channel cache to be ready.

[Kronifer]

I could spin up a quick fix for this tonight

[ChrisLovering]

In addition to the issue that was fixed in the above PR, we are now seeing this happen again.

The issue is that the edited message could be in a DM, so waiting for guild available isn't enough. We should move the message.guild check from self.is_message_blacklisted() "further up" this function, before we try to get the channel.

[TizzySaurus]

We should move the message.guild check from self.is_message_blacklisted() "further up" this function, before we try to get the channel.

So is this just a case of moving L739-L740 above L733-L737?

If so, I can implement this tomorrow.

[ChrisLovering]

Yea, I believe it would be.