Sanitize bot output#1032
Merged
Merged
Conversation
sco1
previously requested changes
Jul 8, 2020
Contributor
Author
this is the only path that repeats the argument
lemon mentioned in #1031 (comment) that the docs don't actually circumvent it very efficiently so it isn't really a problem |
lemonsaurus
approved these changes
Jul 9, 2020
Contributor
lemonsaurus
left a comment
There was a problem hiding this comment.
I think this is more or less a complete solution. There may be edge cases that aren't caught by this, but it's a big enough step in the right direction that I'm comfortable moving forward with it.
The code quality is quite excellent, too. Nice work.
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
Contributor
|
@slushiegoose Can you sort out the failing test? |
MarkKoz
requested changes
Jul 12, 2020
MarkKoz
requested changes
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1031
This removes the argument from the BadArgument command and runs filters over
!evaloutput, as requested.