Allow ordering talentpool/bigbrother watched users by oldest added#1044
Merged
Conversation
ghost
added
the
Den4200
reviewed
Jul 14, 2020
kwzrd
approved these changes
Jul 14, 2020
Contributor
kwzrd
left a comment
kwzrd
left a comment
There was a problem hiding this comment.
Looks and works just fine, excellent work.
Leaving one comment just to make sure it's intentional ~ feel free to merge.
Comment on lines
+290
to
+292
| async def list_watched_users( | ||
| self, ctx: Context, oldest_first: bool = False, update_cache: bool = True | ||
| ) -> None: |
Contributor
There was a problem hiding this comment.
Method signature still fits within 120 chars, is this broken down intentionally? I don't mind it, just wondering.
Additionally, the oldest_first param isn't documented in the docstring (it is in the commands), but I think it's self-explanatory and doesn't need to be mentioned.
kwzrd
changed the title
kwzrd
added
a: moderation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
!talentpool watchedand adds a new command!talentpool oldestto allow convenient listing of talent pool nominees by oldest added.Screenshots
New argument is added to
!talentpool watched:!talentpool watchedwitholdest_first = True:!talentpool oldestis added for convenience: