Invoke fuzzywuzzy's processor before matching#1045
Merged
Conversation
Trying to match a string with only non-alphanumeric characters results in a warning by fuzzywuzzy. Processing the string before matching lets us avoid the warning, which which uses the root logger and thus isn't supressible.
kosayoda
requested review from
SebastiaanZ and
aeros
and removed request for
a team
MarkKoz
requested changes
Jul 15, 2020
ghost
added
s: waiting for author
Fixes a regression where the string to be matched was not processed beforehand.
ghost
added
needs 2 approvals
and removed
s: waiting for author
MarkKoz
added
a: information
Den4200
approved these changes
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #980
Trying to match a string with only non-alphanumeric characters results in a warning by fuzzywuzzy.
Processing the string before matching lets us avoid the warning, which uses the root logger and thus isn't supressible.