Update or-gotcha.md#1046
Merged
Merged
Conversation
Adjust description and include link to docs
ItsCinnabar
requested review from
fiskenslakt and
kwzrd
and removed request for
a team
|
Thank you for contributing to Python Discord! Please check out the following documents:
|
lemonsaurus
approved these changes
Jul 14, 2020
Contributor
|
Discord mobile markdown is a bit messed up and in text links, the formatting gets ignored. |
SebastiaanZ
previously approved these changes
Jul 14, 2020
Contributor
SebastiaanZ
left a comment
SebastiaanZ
left a comment
There was a problem hiding this comment.
Alright, looking good.
Contributor
|
I can't replicate the formatting issue on android, which means I can't experiment with it. I'm wondering if this would give better results: In Python, you should have _[complete instructions on both sides of the logical operator](https://docs.python.org/3/reference/expressions.html#boolean-operations)_. |
SebastiaanZ
suggested changes
Jul 14, 2020
ghost
added
s: waiting for author
Co-authored-by: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
ghost
added
needs 1 approval
and removed
s: waiting for author
kwzrd
approved these changes
Jul 14, 2020
Contributor
There was a problem hiding this comment.
Can confirm this now looks fine on Android. On iOS though, no cursive.
Which is fine, I think.
SebastiaanZ
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust description and include link to docs