Truncate charinfo results#1062
Conversation
MarkKoz
added
t: bug
MarkKoz
requested review from
dementati and
manusaurio
and removed request for
a team
Numerlor
left a comment
Numerlor
left a comment
There was a problem hiding this comment.
Leaving the whole raw message should be fine, at least it should be clear that it's the whole text after switching pages.
Implementation looks fine for the issue, but with the paginator in place, could we use a bigger char limit? Currently it'll only trigger in edge cases like the one in the issue
kosayoda
left a comment
kosayoda
left a comment
There was a problem hiding this comment.
Looks good.
Now that we paginate the characters, can we reduce the number of lines per page so the embed doesn't get chunky? We could also do with an increase with a number of characters allowed, I don't mind it being 10 lines per page, with a 50 character max.
ghost
added
s: waiting for author
Since the raw field is displayed on every page, but pages are incomplete, it may be unclear whether the field's value is for the current page or for all pages. Co-authored-by: Kieran Siek <kieransiek@protonmail.com>
ghost
added
needs 1 approval
and removed
s: waiting for author
Pagination means more characters can be supported without cluttering anything. It also means infinite lines, so there's no longer a need to squeeze out the most from a single page. Reducing the line limit leads to a smaller, tidier presentation.
I was tempted but I ended up waiting for someone else to suggest it 👍 |
Co-authored-by: Kieran Siek <kieransiek@protonmail.com>
3 participants
Fixes #897
Just uses the
LinePaginator. Therawfield is present and has the exact same value on every page. I'm concerned it may be unclear whether the value is only for the current page or for the entire input (the truth is the latter).I also updated the command to use the new
send_denialutility function since the existing code was quite similar to what the helper does. The difference is thatsend_denialhas those comedic titles.