Check that embed desc is not Empty before stripping.#1064
Merged
Conversation
kosayoda
requested review from
scragly and
tagptroll1
and removed request for
a team
ghost
added
the
MarkKoz
approved these changes
Jul 23, 2020
Den4200
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1036
I checked uses of embeds in other parts of the code to see if any of them perform methods on embed attributes, but couldn't find any. I might've missed something though.
The ones that use embed attributes as conditions (
if not embed.url) are fine asEmbed.Emptyobjects are falsy.